CA-405404: Fix path to dracut #6250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On all platforms tested the canonical location for dracut is `/usr/bin/dracut`. Older platforms symlink to it from `/usr/sbin/dracut`, whilst newer ones do not, thus on these platforms xapi is unable to find dracut and fails to start. Adjust the path to the canonical location to ensure it operates correctly on all platforms. Also adjust a reference in network_utils.ml (whilst newer platforms also seem to have the symlink from `/sbin/dracut`, it would seem to make sense to point to the canonical location regardless). Signed-off-by: Alex Brett <[email protected]>
MarkSymsCtx
approved these changes
Jan 25, 2025
|
Question: Do we really need full path? Or PATH environment is enough? |
freddy77
approved these changes
Jan 25, 2025
lindig
approved these changes
Jan 27, 2025
edwintorok
reviewed
Jan 27, 2025
I think the one in Xapi_globs (if passed to |
robhoes
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On all platforms tested the canonical location for dracut is
/usr/bin/dracut. Older platforms symlink to it from/usr/sbin/dracut, whilst newer ones do not, thus on these platforms xapi is unable to find dracut and fails to start.Adjust the path to the canonical location to ensure it operates correctly on all platforms.
Also adjust a reference in network_utils.ml (whilst newer platforms also seem to have the symlink from
/sbin/dracut, it would seem to make sense to point to the canonical location regardless).